Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: workaround for gclient python3 issues #32140

Closed
wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

gclient doesn't support Python 3 yet. To workaround that problem, add an
enviroment variable to override the Python version used by ./configure.

Signed-off-by: Matheus Marchini mmarchini@netflix.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

gclient doesn't support Python 3 yet. To workaround that problem, add an
enviroment variable to override the Python version used by ./configure.

Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Mar 8, 2020
@mmarchini mmarchini mentioned this pull request Mar 8, 2020
15 tasks
@rvagg
Copy link
Member

rvagg commented Mar 9, 2020

cc @nodejs/python

@cclauss
Copy link
Contributor

cclauss commented Mar 9, 2020

Do we really need to rely on gclient? If it was a production worthy tool, surely it would have been upgraded by now.

@BridgeAR
Copy link
Member

BridgeAR commented Mar 9, 2020

Just looking at a recent gclient commit, it seems that Python 3 is now supported?

@mmarchini
Copy link
Contributor Author

Do we really need to rely on gclient? If it was a production worthy tool, surely it would have been upgraded by now.

Yes, gclient is the only supported way to build V8. The alternative would be for us to maintain gyp files for V8 tests as well, which is not worth it.

Just looking at a recent gclient commit, it seems that Python 3 is now supported?

Oh, nice. Python 3 support is behind an environment variable apparently. Let me test locally (but I think it never failed locally for me, so maybe there's also a problem in our CI, in which case I would rather land this to unbreak the CI and investigate the issue further later).

@mmarchini
Copy link
Contributor Author

mmarchini commented Mar 9, 2020

@targos
Copy link
Member

targos commented Mar 9, 2020

I was just able to run gclient sync on my V8 clone and I do not have Python 2 installed on my machine.

@mmarchini
Copy link
Contributor Author

mmarchini commented Mar 9, 2020

Still failing, even though gclient doesn't complain about Python 3 with the environment variable set.

07:43:05 Failed to fetch file gs://chromium-clang-format/942fc8b1789144b8071d3fc03ff0fcbe1cf81ac8 for v8/buildtools/linux64/clang-format. [Err: gsutil requires python 2.6 or 2.7.
07:43:05 ]
07:43:05 0> Failed to fetch file gs://chromium-clang-format/942fc8b1789144b8071d3fc03ff0fcbe1cf81ac8 for v8/buildtools/linux64/clang-format, skipping. [Err: gsutil requires python 2.6 or 2.7.
07:43:05 ]
07:43:05 Downloading 1 files took 4.206573 second(s)
07:43:05 Error: Command 'download_from_google_storage --no_resume --platform=linux* --no_auth --bucket chromium-clang-format -s v8/buildtools/linux64/clang-format.sha1' returned non-zero exit status 1 in .

I'm running one with GCLIENT_PY3 on top of canary-base, but I expect the same failure.

I think there's something else wrong in our CI. But investigating it will probably take time, so I'm still in favor of landing this PR to unbreak our CI.

@cclauss cclauss self-requested a review March 10, 2020 12:56
mmarchini added a commit that referenced this pull request Mar 10, 2020
gclient doesn't support Python 3 yet. To workaround that problem, add an
enviroment variable to override the Python version used by ./configure.

Signed-off-by: Matheus Marchini <mmarchini@netflix.com>

PR-URL: #32140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
@mmarchini
Copy link
Contributor Author

Landed in de8fab9

@mmarchini mmarchini closed this Mar 10, 2020
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
gclient doesn't support Python 3 yet. To workaround that problem, add an
enviroment variable to override the Python version used by ./configure.

Signed-off-by: Matheus Marchini <mmarchini@netflix.com>

PR-URL: #32140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants