Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: eos make const state const #32031

Closed
wants to merge 3 commits into from
Closed

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 1, 2020

writable & readable is based on type and is not actual state, treat them as such. Also fixes an invalid test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag requested a review from mafintosh March 1, 2020 18:21
@ronag ronag requested review from mcollina and mafintosh and removed request for mafintosh March 1, 2020 18:21
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem. wip Issues and PRs that are still a work in progress. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 1, 2020
@ronag
Copy link
Member Author

ronag commented Mar 1, 2020

CI failed, needs investigating

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed wip Issues and PRs that are still a work in progress. labels Mar 1, 2020
@nodejs-github-bot
Copy link
Collaborator

@ronag ronag requested a review from lpinca March 1, 2020 19:51
lib/internal/streams/end-of-stream.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

writable & readable is based on type and is not actual
state, treat them as such.
@ronag
Copy link
Member Author

ronag commented Mar 3, 2020

rebased to fix conflicts

@nodejs-github-bot
Copy link
Collaborator

ronag added a commit that referenced this pull request Mar 3, 2020
writable & readable is based on type and is not actual
state, treat them as such.

PR-URL: #32031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ronag
Copy link
Member Author

ronag commented Mar 3, 2020

Landed in 8429295

@MylesBorins
Copy link
Contributor

This doesn't land cleanly on v13.x. If it is applicable to that release line could you please open a backporrt

ronag added a commit to nxtedition/node that referenced this pull request Mar 10, 2020
writable & readable is based on type and is not actual
state, treat them as such.

PR-URL: nodejs#32031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Backport-PR-URL: nodejs#32178
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
writable & readable is based on type and is not actual
state, treat them as such.

Backport-PR-URL: #32178
PR-URL: #32031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants