Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated YAML version representation in readline.md #31924

Merged
merged 0 commits into from
Feb 25, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 23, 2020

All other versions in YAML throughout the docs start with v. Fix two
cases in readline.md that did not.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Feb 23, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 25, 2020
@Trott
Copy link
Member Author

Trott commented Feb 25, 2020

Landed in 24aa9bd

@Trott Trott closed this Feb 25, 2020
@Trott Trott deleted the v branch February 25, 2020 21:53
@Trott Trott merged commit 24aa9bd into nodejs:master Feb 25, 2020
codebytere pushed a commit that referenced this pull request Feb 27, 2020
All other versions in YAML throughout the docs start with _v_. Fix two
cases in `readline.md` that did not.

PR-URL: #31924
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
All other versions in YAML throughout the docs start with _v_. Fix two
cases in `readline.md` that did not.

PR-URL: #31924
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
All other versions in YAML throughout the docs start with _v_. Fix two
cases in `readline.md` that did not.

PR-URL: #31924
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
All other versions in YAML throughout the docs start with _v_. Fix two
cases in `readline.md` that did not.

PR-URL: #31924
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants