Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-gc-net-timeout #31918

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Feb 22, 2020

If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

If the timeout is called in the time between 'end' and 'close'
that would cause a EPIPE error. Essentially making the test flaky.
@ronag ronag added net Issues and PRs related to the net subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 22, 2020
@ronag ronag requested a review from addaleax February 22, 2020 21:03
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 22, 2020
@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 22, 2020
@nodejs-github-bot
Copy link
Collaborator

@ronag ronag mentioned this pull request Feb 22, 2020
4 tasks
@@ -12,6 +12,9 @@ function serverHandler(sock) {
sock.on('close', function() {
clearTimeout(timer);
});
sock.on('end', function() {
Copy link
Member Author

@ronag ronag Feb 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'end' will cause the writable side to be end():d due to allowHalfOpen: false.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29300/ (:heavy_check_mark:)

@ronag
Copy link
Member Author

ronag commented Mar 1, 2020

The same change got an approval in another PR (#31806) so I will consider that as the second required approval.

ronag added a commit that referenced this pull request Mar 1, 2020
If the timeout is called in the time between 'end' and 'close'
that would cause a EPIPE error. Essentially making the test flaky.

PR-URL: #31918
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ronag
Copy link
Member Author

ronag commented Mar 1, 2020

Landed in 1e8625c

@ronag ronag closed this Mar 1, 2020
@codebytere codebytere mentioned this pull request Mar 3, 2020
codebytere pushed a commit that referenced this pull request Mar 3, 2020
If the timeout is called in the time between 'end' and 'close'
that would cause a EPIPE error. Essentially making the test flaky.

PR-URL: #31918
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
If the timeout is called in the time between 'end' and 'close'
that would cause a EPIPE error. Essentially making the test flaky.

PR-URL: #31918
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
If the timeout is called in the time between 'end' and 'close'
that would cause a EPIPE error. Essentially making the test flaky.

PR-URL: #31918
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
If the timeout is called in the time between 'end' and 'close'
that would cause a EPIPE error. Essentially making the test flaky.

PR-URL: #31918
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants