Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: use let instead of var #31592

Closed
wants to merge 1 commit into from
Closed

benchmark: use let instead of var #31592

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Jan 31, 2020

Use let in module, napi, net, os, path, process, querystring, streams
and string_decoder.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dnlup
benchmark: use let instead of var
af8dcca 
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. module Issues and PRs related to the module subsystem. net Issues and PRs related to the net subsystem. os Issues and PRs related to the os subsystem. path Issues and PRs related to the path subsystem. labels Jan 31, 2020
@Trott
Copy link
Member

Trott commented Feb 2, 2020

Assuming this gets rid of all instances of var in the benchmark directory, we should probably enable the no-var ESLint rule in benchmark/.eslintrc.yaml.

@Trott
Copy link
Member

Trott commented Feb 2, 2020

Benchmark (and, because I forgot to remove them, also pummel and internet) CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11958/

@richardlau
Copy link
Member

There's overlap between this PR and #28958.

@dnlup
Copy link
Contributor Author

dnlup commented Feb 3, 2020

@Trott @richardhoehn this still doesn' get rid of all the var. I could continue the removal in this PR and then add the rule if it's ok or, given the overlap with #28958, open a new PR (sorry I missed that PR).

addaleax pushed a commit that referenced this pull request Feb 13, 2020
@dnlup @addaleax
benchmark: use let instead of var
4bf888d 
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.

PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax
Copy link
Member

Landed in 4bf888d

@addaleax addaleax closed this Feb 13, 2020
@dnlup dnlup mentioned this pull request Feb 14, 2020
Closed
2 tasks
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@dnlup @codebytere
benchmark: use let instead of var
2de085f 
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.

PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@dnlup @codebytere
benchmark: use let instead of var
5bcd73f 
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.

PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@dnlup @codebytere
benchmark: use let instead of var
8538494 
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.

PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@dnlup @codebytere
benchmark: use let instead of var
0b75790 
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.

PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@antsmartian antsmartian antsmartian approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. module Issues and PRs related to the module subsystem. net Issues and PRs related to the net subsystem. os Issues and PRs related to the os subsystem. path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dnlup @Trott @richardlau @addaleax @jasnell @antsmartian @nodejs-github-bot