Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update collaborator guide with citgm instructions #31549

Closed
wants to merge 6 commits into from
Closed

docs: update collaborator guide with citgm instructions #31549

wants to merge 6 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 28, 2020

Adds more information about running CITGM jobs.

Note, not sure what commit prefix to use in the root?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag requested a review from Trott January 28, 2020 13:17
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 28, 2020
@ronag
Copy link
Member Author

ronag commented Jan 28, 2020

@nodejs/documentation

addaleax
addaleax approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ronag
Copy link
Member Author

ronag commented Jan 28, 2020

credit to @Trott :)

richardlau
richardlau reviewed Jan 28, 2020
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
richardlau
richardlau reviewed Jan 28, 2020
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
richardlau
richardlau approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM if you add the new section to the TOC.

@richardlau
Copy link
Member

(And for whoever lands this the subsystem is usually doc (without the s). Travis CI does flag this (on the "Checks" tab and in Travis itself) but we marked the job as allowed to fail so it won't show up on this tab. git node land should also complain.)

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2020
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Trott
Trott approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without the little nits I left. Thanks for doing this!

ronag and others added 2 commits January 30, 2020 08:29
@ronag @Trott
Update COLLABORATOR_GUIDE.md
e044298 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@ronag @Trott
Apply suggestions from code review
4c9502b 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@ronag
Copy link
Member Author

ronag commented Jan 30, 2020 •
edited
Loading

Landed in 1d95111

@ronag ronag closed this Jan 30, 2020
ronag added a commit that referenced this pull request Jan 30, 2020
@ronag
doc: update collaborator guide citgm instructions
1d95111 
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@ronag @codebytere
doc: update collaborator guide citgm instructions
e2b3e4e 
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@ronag @codebytere
doc: update collaborator guide citgm instructions
a404806 
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@ronag @codebytere
doc: update collaborator guide citgm instructions
173376e 
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@ronag @codebytere
doc: update collaborator guide citgm instructions
5286ccc 
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ronag @richardlau @jasnell @Trott @addaleax @lpinca @BethGriggs @nodejs-github-bot