test: refactor readline interface test #31423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/readline @nodejs/testing PTAL. This file is the most important test file we have for all readline tests. |
|
Needs a rebase. |
jasnell
approved these changes
Jan 23, 2020
This reduces the code lines required to run the tests by abstracting the constructor call. It also moves tests out of a for loop that where miss placed.
BridgeAR
force-pushed
the
2020-01-20-test-refactor-readline-interface
branch
from
69c953f
to
6a285f3
Compare
BridgeAR
added
the
author ready
This reverts commit fe7bdc0.
Trott
approved these changes
Jan 27, 2020
BridgeAR
added a commit
that referenced
this pull request
Feb 5, 2020
This reduces the code lines required to run the tests by abstracting the constructor call. It also moves tests out of a for loop that where miss placed. PR-URL: #31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
added a commit
that referenced
this pull request
Feb 5, 2020
PR-URL: #31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
This reduces the code lines required to run the tests by abstracting the constructor call. It also moves tests out of a for loop that where miss placed. PR-URL: #31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
PR-URL: #31423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
added
backport-requested-v12.x
and removed
author ready
4 tasks
|
Would you like to backport this to v12.x? I'm preparing the next minor on this branch: https://github.com/targos/node/commits/prepare-minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring is mainly there to improve the readability of the tests and to reduce code lines.
Multiple tests where misplaced and this is now corrected as well. The misplacement makes the diff not that easy to read but functionality wise it's 100% identical as before.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes