Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps,test: update to uvwasi 0.0.4 #31363

Closed
wants to merge 3 commits into from
Closed

deps,test: update to uvwasi 0.0.4 #31363

wants to merge 3 commits into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 15, 2020

This commit updates the uvwasi dependency to version 0.0.4. The
most notable change is a refactor of the way paths are resolved.
All paths, including symlinks, are now resolved in terms of
sandboxed paths instead of leaking host system paths.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the wasi Issues and PRs related to the WebAssembly System Interface. label Jan 15, 2020
@richardlau
Copy link
Member

It's probably not a major thing since it's just a warning but nodejs/uvwasi#72 didn't make it into this release?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 15, 2020

Oops. I'll fix that.

@cjihrig
deps,test: update to uvwasi 0.0.4
0c4ba5d 
This commit updates the uvwasi dependency to version 0.0.4. The
most notable change is a refactor of the way paths are resolved.
All paths, including symlinks, are now resolved in terms of
sandboxed paths instead of leaking host system paths.
@cjihrig
deps: port uvwasi@676ba9a to gyp
3e1a402 
This commit ports nodejs/uvwasi@676ba9a
from CMake to gyp.
@cjihrig
deps: uvwasi: cherry-pick 941bedf
248e946 
Original commit message:

    nodejs/uvwasi@20fd9e2 was
    accidentally reverted in
    nodejs/uvwasi#73. This commit
    relands it.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28458/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28459/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28460/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28461/

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 17, 2020

^ I think the CI is passing, but a Java exception is thrown after the test suite finishes.

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/28462/ ✅

@Trott
Copy link
Member

Trott commented Jan 17, 2020

^ I think the CI is passing, but a Java exception is thrown after the test suite finishes.

Looks like a problem with test-requireio_pivotalagency-debian10-arm64_pi3-1. I've taken it offline. Hopefully that will fix things. /ping @rvagg

@Trott
Copy link
Member

Trott commented Jan 17, 2020

Landed in e43ee37...d43e945

Trott pushed a commit that referenced this pull request Jan 17, 2020
@cjihrig @Trott
deps,test: update to uvwasi 0.0.4
12ff616 
This commit updates the uvwasi dependency to version 0.0.4. The
most notable change is a refactor of the way paths are resolved.
All paths, including symlinks, are now resolved in terms of
sandboxed paths instead of leaking host system paths.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Trott pushed a commit that referenced this pull request Jan 17, 2020
@cjihrig @Trott
deps: port uvwasi@676ba9a to gyp
87ffc6e 
This commit ports nodejs/uvwasi@676ba9a
from CMake to gyp.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Trott pushed a commit that referenced this pull request Jan 17, 2020
@cjihrig @Trott
deps: uvwasi: cherry-pick 941bedf
d43e945 
Original commit message:

    nodejs/uvwasi@20fd9e2 was
    accidentally reverted in
    nodejs/uvwasi#73. This commit
    relands it.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott closed this Jan 17, 2020
@cjihrig cjihrig deleted the wasi branch January 17, 2020 13:57
@bricss bricss mentioned this pull request Jan 19, 2020
Merged
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@cjihrig @codebytere
deps,test: update to uvwasi 0.0.4
5bd3f6c 
This commit updates the uvwasi dependency to version 0.0.4. The
most notable change is a refactor of the way paths are resolved.
All paths, including symlinks, are now resolved in terms of
sandboxed paths instead of leaking host system paths.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@cjihrig @codebytere
deps: port uvwasi@676ba9a to gyp
00e38a7 
This commit ports nodejs/uvwasi@676ba9a
from CMake to gyp.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@cjihrig @codebytere
deps: uvwasi: cherry-pick 941bedf
7c4f1ed 
Original commit message:

    nodejs/uvwasi@20fd9e2 was
    accidentally reverted in
    nodejs/uvwasi#73. This commit
    relands it.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@cjihrig @codebytere
deps,test: update to uvwasi 0.0.4
e849b15 
This commit updates the uvwasi dependency to version 0.0.4. The
most notable change is a refactor of the way paths are resolved.
All paths, including symlinks, are now resolved in terms of
sandboxed paths instead of leaking host system paths.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@cjihrig @codebytere
deps: port uvwasi@676ba9a to gyp
cadab5b 
This commit ports nodejs/uvwasi@676ba9a
from CMake to gyp.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@cjihrig @codebytere
deps: uvwasi: cherry-pick 941bedf
dbe7ede 
Original commit message:

    nodejs/uvwasi@20fd9e2 was
    accidentally reverted in
    nodejs/uvwasi#73. This commit
    relands it.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@cjihrig @codebytere
deps,test: update to uvwasi 0.0.4
676e3c3 
This commit updates the uvwasi dependency to version 0.0.4. The
most notable change is a refactor of the way paths are resolved.
All paths, including symlinks, are now resolved in terms of
sandboxed paths instead of leaking host system paths.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@cjihrig @codebytere
deps: port uvwasi@676ba9a to gyp
ef5517a 
This commit ports nodejs/uvwasi@676ba9a
from CMake to gyp.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@cjihrig @codebytere
deps: uvwasi: cherry-pick 941bedf
8cf2666 
Original commit message:

    nodejs/uvwasi@20fd9e2 was
    accidentally reverted in
    nodejs/uvwasi#73. This commit
    relands it.

PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@tniessen tniessen tniessen approved these changes

@devnexen devnexen devnexen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @richardlau @nodejs-github-bot @Trott @tniessen @devnexen