Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update remark-preset-lint-node to 1.12.0 #31359

Merged
merged 0 commits into from
Jan 15, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 14, 2020

This adds linting for "hostname" in prose.

This also re-adds @zeit/ncc which is required to build. It was removed in 80fb153 but that was in error.

I'd like to fast-track this to prevent other instances of "hostname" from slipping in while this remains open. 👍 here to approve, or comment to block.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 14, 2020
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed tools Issues and PRs related to the tools directory. labels Jan 14, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2020
@Trott
Copy link
Member Author

Trott commented Jan 15, 2020

@nodejs/linting

@Trott
Copy link
Member Author

Trott commented Jan 15, 2020

Landed in 6623481...7ab33f2

Trott added a commit to Trott/io.js that referenced this pull request Jan 15, 2020
This adds linting for "hostname" in prose.

PR-URL: nodejs#31359
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott Trott closed this Jan 15, 2020
@Trott Trott merged commit 7ab33f2 into nodejs:master Jan 15, 2020
@Trott Trott deleted the lint-host-name branch January 15, 2020 23:52
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
This adds linting for "hostname" in prose.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
Remove rollup dependencies in markdown linting tool's package.json. We
use @zeit/ncc.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Jan 16, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
This adds linting for "hostname" in prose.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
Remove rollup dependencies in markdown linting tool's package.json. We
use @zeit/ncc.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This adds linting for "hostname" in prose.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Remove rollup dependencies in markdown linting tool's package.json. We
use @zeit/ncc.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants