Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: silence warnings from dependencies #31311

Closed
wants to merge 2 commits into from
Closed

build: silence warnings from dependencies #31311

wants to merge 2 commits into from

Conversation

richardlau
Copy link
Member

Silence compiler warnings on Windows from our dependencies that are being
shown as Unchanged files with check annotations by GitHub in the
Files changed tab on pull requests since we started building via GitHub Actions
in #31153.

e.g.
image

(I've separately upstreamed a fix for the uvwasi warning: nodejs/uvwasi#72.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau
build: silence c-ares Windows compiler warnings
f771f8d 
Silence the following compiler warning on Windows:
`inet_addr': Use inet_pton() or InetPton() instead or define
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings`
@richardlau
build: silence OpenSSL Windows compiler warnings
307544c 
Silence the following compiler warning on Windows:
`'function': different 'const' qualifiers`
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Jan 11, 2020
richardlau
richardlau commented Jan 11, 2020
View reviewed changes
deps/openssl/openssl_common.gypi
@@ -32,6 +32,7 @@
'cflags': [
'-W3', '-wd4090', '-Gs0', '-GF', '-Gy', '-nologo','/O2',
],
'msvs_disabled_warnings': [4090],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell (setting the msbuild_args=/clp:Verbosity=n environment variable before calling vcbuild to get verbose command lines being passed to cl.exe) the above cflags (containing -wd4090 which should suppress the warning) is being ignored. I've left the cflags alone for now as I can't be sure it isn't used in non-msvs scenarios on Windows (Ninja?).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, OpenSSL's own build configuration ignores the same warning:

node/deps/openssl/openssl/Configurations/10-main.conf

Lines 1199 to 1202 in be055d1

# Note about /wd4090, disable warning C4090. This warning returns false
# positives in some situations. Disabling it altogether masks both
# legitimate and false cases, but as we compile on multiple platforms,
# we rely on other compilers to catch legitimate cases.

@richardlau richardlau added openssl Issues and PRs related to the OpenSSL dependency. windows Issues and PRs related to the Windows platform. labels Jan 11, 2020
@richardlau richardlau changed the title Warnings build: fix warnings from dependencies Jan 11, 2020
@richardlau richardlau changed the title build: fix warnings from dependencies build: silence warnings from dependencies Jan 11, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28361/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28362/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 11, 2020
@richardlau richardlau mentioned this pull request Jan 12, 2020
Closed
@BridgeAR
Copy link
Member

Landed in 560df95, c643e3b 🎉

@BridgeAR BridgeAR closed this Jan 13, 2020
BridgeAR pushed a commit that referenced this pull request Jan 13, 2020
@richardlau @BridgeAR
build: silence c-ares Windows compiler warnings
560df95 
Silence the following compiler warning on Windows:
`inet_addr': Use inet_pton() or InetPton() instead or define
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings`

PR-URL: #31311
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 13, 2020
@richardlau @BridgeAR
build: silence OpenSSL Windows compiler warnings
c643e3b 
Silence the following compiler warning on Windows:
`'function': different 'const' qualifiers`

PR-URL: #31311
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau deleted the warnings branch January 13, 2020 10:43
@richardlau richardlau mentioned this pull request Jan 13, 2020
Closed
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@richardlau @MylesBorins
build: silence c-ares Windows compiler warnings
6b118b4 
Silence the following compiler warning on Windows:
`inet_addr': Use inet_pton() or InetPton() instead or define
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings`

PR-URL: #31311
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@richardlau @MylesBorins
build: silence OpenSSL Windows compiler warnings
a31eed0 
Silence the following compiler warning on Windows:
`'function': different 'const' qualifiers`

PR-URL: #31311
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@richardlau @codebytere
build: silence c-ares Windows compiler warnings
0184bcd 
Silence the following compiler warning on Windows:
`inet_addr': Use inet_pton() or InetPton() instead or define
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings`

PR-URL: #31311
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@richardlau @codebytere
build: silence OpenSSL Windows compiler warnings
5be9958 
Silence the following compiler warning on Windows:
`'function': different 'const' qualifiers`

PR-URL: #31311
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@richardlau @codebytere
build: silence c-ares Windows compiler warnings
a89893f 
Silence the following compiler warning on Windows:
`inet_addr': Use inet_pton() or InetPton() instead or define
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings`

PR-URL: #31311
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@richardlau @codebytere
build: silence OpenSSL Windows compiler warnings
93a7f91 
Silence the following compiler warning on Windows:
`'function': different 'const' qualifiers`

PR-URL: #31311
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. openssl Issues and PRs related to the OpenSSL dependency. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@richardlau @nodejs-github-bot @BridgeAR @jasnell @Trott @addaleax @lpinca @cjihrig