Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: move tmpDir() to EOL #31169

Closed
wants to merge 2 commits into from
Closed

os: move tmpDir() to EOL #31169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
957084a
os: move tmpDir() to EOL
jasnell Jan 2, 2020
27bca6e
fixup! os: move tmpDir() to EOL
jasnell Feb 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,14 +508,18 @@ The `Server.listenFD()` method was deprecated and removed. Please use
### DEP0022: `os.tmpDir()`
<!-- YAML
changes:
- version: REPLACEME
pr-url: REPLACEME
description: End-of-Life.
- version: v7.0.0
pr-url: https://github.com/nodejs/node/pull/6739
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `os.tmpDir()` API is deprecated. Please use [`os.tmpdir()`][] instead.
The `os.tmpDir()` API iws deprecated in Node.js 7.0.0 and has since been
jasnell marked this conversation as resolved.
Show resolved Hide resolved
removed. Please use [`os.tmpdir()`][] instead.

<a id="DEP0023"></a>
### DEP0023: `os.getNetworkInterfaces()`
Expand Down
7 changes: 0 additions & 7 deletions lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const {

const { safeGetenv } = internalBinding('credentials');
const constants = internalBinding('constants').os;
const { deprecate } = require('internal/util');
const isWindows = process.platform === 'win32';

const {
Expand Down Expand Up @@ -83,9 +82,6 @@ getUptime[SymbolToPrimitive] = () => getUptime();

const kEndianness = isBigEndian ? 'BE' : 'LE';

const tmpDirDeprecationMsg =
'os.tmpDir() is deprecated. Use os.tmpdir() instead.';

const avgValues = new Float64Array(3);

function loadavg() {
Expand Down Expand Up @@ -285,9 +281,6 @@ module.exports = {
type: getOSType,
userInfo,
uptime: getUptime,

// Deprecated APIs
tmpDir: deprecate(tmpdir, tmpDirDeprecationMsg, 'DEP0022')
jasnell marked this conversation as resolved.
Show resolved Hide resolved
};

ObjectDefineProperties(module.exports, {
Expand Down