Revert "deps: V8: cherry-pick 687d865fe251" #31098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e21c1e. It landed without a proper v8_embedder_string bump, reverting to re-land cleanly. Refs: 0e21c1e Refs: nodejs#31007
ChALkeR
added
v8 engine
This was referenced Dec 26, 2019
jasnell
approved these changes
Dec 26, 2019
|
I personally prefer the approach in #31096 of just bumping the string... it is what I've personally done before in the past. Won't block this landing though. |
|
I’m closing this out because there seems to be consensus that either #31096 or doing nothing is preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0e21c1e.
It landed without a proper
v8_embedder_stringbump, reverting to re-land #31007 cleanly after that.Refs: 0e21c1e
Refs: #31007
Possible alternative actions:
v8_embedder_stringseparately (PR: deps: V8: bump v8_embedder_string for 0e21c1e637bf #31096)v8_embedder_stringhas been just updated by another V8 patch).Either of those seems fine to me, opening all the possible ones to speed up things.