test: fix common.enoughTestMem #31035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
fast-track
cjihrig
approved these changes
Dec 20, 2019
richardlau
approved these changes
Dec 20, 2019
gireeshpunathil
approved these changes
Dec 20, 2019
BridgeAR
approved these changes
Dec 20, 2019
devnexen
approved these changes
Dec 20, 2019
|
Landed in 118b28a |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
A typo introduced in 1ddcb6d causes common.enoughTestMem to always be false, resulting in a lot of tests being skipped. Fix the typo. PR-URL: #31035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
A typo introduced in 1ddcb6d causes common.enoughTestMem to always be false, resulting in a lot of tests being skipped. Fix the typo. PR-URL: #31035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
A typo introduced in 1ddcb6d causes common.enoughTestMem to always be false, resulting in a lot of tests being skipped. Fix the typo. PR-URL: #31035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typo introduced in 1ddcb6d causes common.enoughTestMem to always
be falsy, resulting in a lot of tests being skipped. Fix the typo.
Collaborators, please 👍 to fast-track (or comment if you believe this shouldn't be fast-tracked).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes