Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: minor fix equality comparison #30898

Closed
wants to merge 1 commit into from
Closed

lib: minor fix equality comparison #30898

wants to merge 1 commit into from

Conversation

PW486
Copy link
Contributor

@PW486 PW486 commented Dec 11, 2019

Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@PW486
lib: minor fix equality comparison
8e7e691 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 11, 2019
BridgeAR
BridgeAR approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a green CI

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27584/

@targos
Copy link
Member

targos commented Dec 12, 2019

don't we still treat punycode as an external dependency that we don't patch directly?

@BridgeAR
Copy link
Member

@targos not anymore as far as I can tell. We did update e.g. var.

Trott
Trott requested changes Dec 13, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a very specific reason that we used == in prof_polyfill but I don't recall what it was.... Going to "request changes" for a bit while I dig through logs to try to find out. Sorry about that.

@Trott
Copy link
Member

Trott commented Dec 13, 2019

There was a very specific reason that we used == in prof_polyfill but I don't recall what it was.... Going to "request changes" for a bit while I dig through logs to try to find out. Sorry about that.

Argh, I see it was recently de-var'ed which I think might also be a problem. I might be confusing it with another file though.

@targos not anymore as far as I can tell. We did update e.g. var.

But it looks like maybe we upstreamed that change....

@Trott
Copy link
Member

Trott commented Dec 13, 2019

This should probably be split into two commits, one for each file?

@Trott
Copy link
Member

Trott commented Dec 13, 2019

@nodejs/v8 @matthewloring Am I wrong about == in v8_prof_polyfill.js being significant somehow? I'm guessing I'm wrong/mistaken/misremembering but I would really prefer to have that confirmed by someone knowledgable.

@BridgeAR
Copy link
Member

@Trott here's an overview for loose equalities: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness#Loose_equality_using

Objects with a Symbol.toPrimitive or toString attached would work differently now (they could match before). Other comparison will not be impacted.

I do not know if that was intentional but I doubt it.

@Trott
Copy link
Member

Trott commented Dec 13, 2019

@Trott here's an overview for loose equalities: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness#Loose_equality_using

Objects with a Symbol.toPrimitive or toString attached would work differently now (they could match before). Other comparison will not be impacted.

I do not know if that was intentional but I doubt it.

I thought it had to do with side effects in V8 under the hood that would affect profiling but not anything normally visible to the end user. I'm probably wrong and will remove my request for changes.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27644/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27666/

Trott pushed a commit that referenced this pull request Dec 14, 2019
@PW486 @Trott
lib: use strict equality comparison
9c460e1 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

PR-URL: #30898
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 14, 2019

Landed in 9c460e1.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 14, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@PW486 @MylesBorins
lib: use strict equality comparison
2430dd8 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

PR-URL: #30898
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@PW486 @targos
lib: use strict equality comparison
9b730ad 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

PR-URL: #30898
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@PW486 @BethGriggs
lib: use strict equality comparison
1c2d699 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

PR-URL: #30898
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@devnexen devnexen devnexen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PW486 @nodejs-github-bot @targos @BridgeAR @Trott @devnexen