net: remove duplicate _undestroy #30833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initSocketHandle will call _undestroy.
|
@Trott: I'm confused by this travis failure. What failed? |
You mean the JS tests in particular? I don't know either. Let's kick off a Jenkins CI and see what that looks like.... |
Trott
approved these changes
Dec 8, 2019
Trott
added
the
author ready
lpinca
approved these changes
Dec 8, 2019
danbev
pushed a commit
that referenced
this pull request
Dec 11, 2019
initSocketHandle will call _undestroy. PR-URL: #30833 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 855ca73. |
targos
pushed a commit
that referenced
this pull request
Dec 11, 2019
initSocketHandle will call _undestroy. PR-URL: #30833 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
initSocketHandle will call _undestroy. PR-URL: #30833 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
initSocketHandle will call _undestroy. PR-URL: #30833 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initSocketHandlewill call_undestroy.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes