Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove imprecise and redundant testing text #30763

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 2, 2019

Remove "All commits...are tested on these platforms." for the following
reasons:

  • It's somewhat redundant. The surrounding text makes it clear that we
    test on these platforms.
  • It's imprecise. Commits, such as those that only affect documentation
    or linting do not get tested on all the platforms. (Well, perhaps they
    do in an after-the-fact kind of way when a subsequent commit gets
    tested, but I think that's a stretch.)
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Dec 2, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2019
Remove "All commits...are tested on these platforms." for the following
reasons:

* It's somewhat redundant. The surrounding text makes it clear that we
  test on these platforms.
* It's imprecise. Commits, such as those that only affect documentation
  or linting do not get tested on all the platforms. (Well, perhaps they
  do in an after-the-fact kind of way when a subsequent commit gets
  tested, but I think that's a stretch.)

PR-URL: nodejs#30763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Copy link
Member Author

Trott commented Dec 5, 2019

Landed in ca11291

@Trott Trott deleted the build branch December 5, 2019 04:09
targos pushed a commit that referenced this pull request Dec 9, 2019
Remove "All commits...are tested on these platforms." for the following
reasons:

* It's somewhat redundant. The surrounding text makes it clear that we
  test on these platforms.
* It's imprecise. Commits, such as those that only affect documentation
  or linting do not get tested on all the platforms. (Well, perhaps they
  do in an after-the-fact kind of way when a subsequent commit gets
  tested, but I think that's a stretch.)

PR-URL: #30763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
targos pushed a commit that referenced this pull request Jan 13, 2020
Remove "All commits...are tested on these platforms." for the following
reasons:

* It's somewhat redundant. The surrounding text makes it clear that we
  test on these platforms.
* It's imprecise. Commits, such as those that only affect documentation
  or linting do not get tested on all the platforms. (Well, perhaps they
  do in an after-the-fact kind of way when a subsequent commit gets
  tested, but I think that's a stretch.)

PR-URL: #30763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Remove "All commits...are tested on these platforms." for the following
reasons:

* It's somewhat redundant. The surrounding text makes it clear that we
  test on these platforms.
* It's imprecise. Commits, such as those that only affect documentation
  or linting do not get tested on all the platforms. (Well, perhaps they
  do in an after-the-fact kind of way when a subsequent commit gets
  tested, but I think that's a stretch.)

PR-URL: #30763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants