Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: document kill() return value #30669

Merged
merged 1 commit into from
Nov 29, 2019
Merged

child_process: document kill() return value #30669

merged 1 commit into from
Nov 29, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 26, 2019

This commit documents the return value from subprocess.kill().

Refs: #30668

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Nov 26, 2019
@cjihrig cjihrig mentioned this pull request Nov 26, 2019
Closed
@jgehrcke
Copy link
Contributor

Thank you, @cjihrig!

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2019
@cjihrig
child_process: document kill() return value
84a25eb 
This commit documents the return value from subprocess.kill().

PR-URL: nodejs#30669
Refs: nodejs#30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 84a25eb into nodejs:master Nov 29, 2019
@cjihrig cjihrig deleted the kill-ret branch November 29, 2019 16:06
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@cjihrig @addaleax
child_process: document kill() return value
30a4f68 
This commit documents the return value from subprocess.kill().

PR-URL: #30669
Refs: #30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@cjihrig @targos
child_process: document kill() return value
a2ef669 
This commit documents the return value from subprocess.kill().

PR-URL: #30669
Refs: #30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@cjihrig @MylesBorins
child_process: document kill() return value
f9f3ab2 
This commit documents the return value from subprocess.kill().

PR-URL: #30669
Refs: #30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgehrcke jgehrcke jgehrcke left review comments

@bnoordhuis bnoordhuis bnoordhuis left review comments

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @jgehrcke @bnoordhuis @jasnell @lpinca @gireeshpunathil @nodejs-github-bot