Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mustCall() to test-inspector-contexts #30649

Merged
merged 4 commits into from
Nov 28, 2019
Merged

test: add mustCall() to test-inspector-contexts #30649

merged 4 commits into from
Nov 28, 2019

Commits on Nov 28, 2019

  1. test: add mustCall() to test-inspector-contexts 

    In test-inspector-contexts, if mainContextPromise is modified such that
the `method` argument is changed to something invalid, the test still
passes and the second part of the test never runs. Use
`common.mustCall()` to cause the test to fail if the second part of the
test does not run.

Refs: nodejs#30519 (comment)

PR-URL: nodejs#30649
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    80c170e View commit details
    Browse the repository at this point in the history

  2. test: check for session.post() errors in test-insepctor-context 

    If session.post() generates an error, it is currently ignored. Add check
for error by adding a callback to session.post() invocation.

PR-URL: nodejs#30649
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    4325ca6 View commit details
    Browse the repository at this point in the history

  3. test: remove destructuring from test-inspector-contexts 

    As I'm working with this test, I'm finding the destructuring of assert
and vm to make this test harder to read/understand. So I'm taking the
liberty of removing them.

PR-URL: nodejs#30649
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    9cefd61 View commit details
    Browse the repository at this point in the history

  4. test: add logging in case of infinite loop 

    test-inspector-contexts may be entering an infinite loop (or very
long-running loop) in CI, resulting in flakiness. Or maybe not. Add
logging to find out.

PR-URL: nodejs#30649
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    15146e6 View commit details
    Browse the repository at this point in the history