Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: fix dynamic import from eval #30624

Closed
wants to merge 2 commits into from

Conversation

coreyfarrell
Copy link
Member

This allows dynamic import to work from CLI --eval with or without
--input-type=module.

Fixes: #30591

Checklist

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Nov 24, 2019
Copy link
Contributor

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 27, 2019
@nodejs-github-bot
Copy link
Collaborator

@coreyfarrell
Copy link
Member Author

I'm not sure what to do here, it doesn't look like the crash is caused by my change?

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

lib/internal/process/execution.js Outdated Show resolved Hide resolved
lib/internal/process/execution.js Outdated Show resolved Hide resolved
@guybedford guybedford requested a review from bcoe December 5, 2019 05:08
@bcoe
Copy link
Contributor

bcoe commented Dec 5, 2019

@coreyfarrell @guybedford this looks quite reasonable to me; @coreyfarrell when you have a moment, want to work on debugging the Travis tests? at which point I can kick off ci/cd?

@coreyfarrell
Copy link
Member Author

@bcoe the travis errors were unrelated and should be fixed by 781e41d, I've rebased to the current master.

@nodejs-github-bot

This comment has been minimized.

@coreyfarrell

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

coreyfarrell and others added 2 commits December 5, 2019 19:39
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: nodejs#30591
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the most recent test run was successful, I am going to go ahead and land this.

bcoe pushed a commit that referenced this pull request Dec 7, 2019
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: #30591

PR-URL: #30624
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@bcoe
Copy link
Contributor

bcoe commented Dec 7, 2019

Landed in 4ec02d5

@bcoe bcoe closed this Dec 7, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: #30591

PR-URL: #30624
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: #30591

PR-URL: #30624
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: #30591

PR-URL: #30624
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic import not working on eval/print
7 participants