doc,deps: document how to maintain ICU in Node.js #30607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
added
doc
nodejs-github-bot
added
tools
|
see also #26090 |
|
Should we also document how to upload the timezone data? Doesn't seem to be covered in current guide and honestly I had to struggle a bit to get it to work |
Yes. But do I have a good answer yet? No. I think it should be easier than what you did (though heroic - 👍) , but I need to take some time to figure out the steps. So I'd like to make that a future PR. This is just to document the floating patch mechanism itself, plus scaffolding for future docs. |
|
oh whoops. @apaprocki has already created a great tz doc in #30364 , how about I just merge that in ? |
3 tasks
richardlau
approved these changes
Nov 23, 2019
|
Is this needed?
|
|
Oops no. A thousand times no.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Michaël Zasso <notifications@github.com>
Sent: Saturday, November 23, 2019 5:20:58 AM
To: nodejs/node <node@noreply.github.com>
Cc: Steven R. Loomis <srl295@gmail.com>; Assign <assign@noreply.github.com>
Subject: Re: [nodejs/node] doc,deps: document how to maintain ICU in Node.js (#30607)
Is this needed?
[image]<https://user-images.githubusercontent.com/2352663/69479349-755a6700-0dfc-11ea-912d-56d22c17f60d.png>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#30607?email_source=notifications&email_token=AAGQZM53NDH2CZECOPHEUWLQVEU3VA5CNFSM4JQXCY52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7VBFI#issuecomment-557797525>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAGQZM3AKV74KHM7ZW3O6KDQVEU3VANCNFSM4JQXCY5Q>.
|
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Nov 26, 2019
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: nodejs#30608 Refs: nodejs#30607 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
srl295
force-pushed
the
doc-icu-patches
branch
from
af3a103
to
4febbfe
Compare
|
OK rebased and cleaned up. PTAL |
|
Looks like there are some linting errors |
- update v8 guide to mention ICU - move content from the tools/icu/README.md but leave a pointer Fixes: nodejs#26108 Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: nodejs#30607
MylesBorins
force-pushed
the
doc-icu-patches
branch
from
4febbfe
to
5e50f4a
Compare
|
I've pushed a fix to the lint. Will land if Travis is Green |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 27, 2019
- update v8 guide to mention ICU - move content from the tools/icu/README.md but leave a pointer Fixes: #26108 Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30607 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
|
landed in f36331c |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: #30608 Refs: #30607 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
- update v8 guide to mention ICU - move content from the tools/icu/README.md but leave a pointer Fixes: #26108 Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30607 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: #30608 Refs: #30607 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: #30608 Refs: #30607 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26108
make -j4 test(UNIX), orvcbuild test(Windows) passes