src: remove unused sync result from ASYNC_CALL #3049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
c++
|
I'm 95% sure some APMs use the return value. |
skomski
force-pushed
the
fix-ufe-req-wrap
branch
2 times, most recently
from
babbc51
to
e3dc2f6
Compare
|
Updated to only fix the use-after-free without removing the unused sync result because APMs maybe use it. |
| @@ -273,8 +273,9 @@ struct fs_req_wrap { | |||
| uv_req->result = err; \ | |||
| uv_req->path = nullptr; \ | |||
| After(uv_req); \ | |||
There was a problem hiding this comment.
Can you set req_wrap = nullptr here?
Aside: the uv_req->path = nullptr is a memory leak waiting to happen. It's mostly benign now - I think.
skomski
force-pushed
the
fix-ufe-req-wrap
branch
from
e3dc2f6
to
9595025
Compare
|
Merge? |
|
CI looks fine except of course stringbytes-external. |
bnoordhuis
pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2015
PR-URL: nodejs#3049 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks Karl, landed in ccaaae9. |
|
@bnoordhuis ... should this land in v4.x before 4.2.0 lts is cut? |
|
It won't hurt. I've added the tag. |
jasnell
pushed a commit
that referenced
this pull request
Oct 9, 2015
PR-URL: #3049 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
landed in v4.x-staging as 2314378 |
This was referenced Sep 17, 2021
This was referenced Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes use-after-free of req_wrap if uv returns early err