Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: replace var with let/const #30417

Closed
wants to merge 3 commits into from
Closed

http2: replace var with let/const #30417

wants to merge 3 commits into from

Conversation

pc3b3r
Copy link
Contributor

@pc3b3r pc3b3r commented Nov 12, 2019

Changed var to let and const on util. Keeping var on for loops.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Nov 12, 2019
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
@pc3b3r @jasnell
Apply suggestions from code review
c04da8c 
Co-Authored-By: James M Snell <jasnell@gmail.com>
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
lib/internal/http2/util.js Outdated Show resolved Hide resolved
@pc3b3r @jasnell
Update lib/internal/http2/util.js
ace8b68 
Co-Authored-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26553/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26782/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26874/

Trott pushed a commit that referenced this pull request Nov 23, 2019
@pc3b3r @Trott
http2: replace var with let/const
0271f1b 
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott
Copy link
Member

Trott commented Nov 23, 2019

Landed in 0271f1b.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 23, 2019
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@pc3b3r @addaleax
http2: replace var with let/const
f7ca7e6 
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@pc3b3r @targos
http2: replace var with let/const
2a44ff5 
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@pc3b3r @MylesBorins
http2: replace var with let/const
bccef49 
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pc3b3r @nodejs-github-bot @Trott @jasnell @gireeshpunathil @BridgeAR @trivikr