Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add mention for using promisify on class methods #30355

Closed
wants to merge 2 commits into from
Closed

doc: add mention for using promisify on class methods #30355

wants to merge 2 commits into from

Conversation

lundibundi
Copy link
Member

Fixes: #30344

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Nov 10, 2019
devsnek
devsnek reviewed Nov 10, 2019
View reviewed changes
doc/api/util.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Nov 10, 2019
View reviewed changes
doc/api/util.md Outdated Show resolved Hide resolved
@BridgeAR
Copy link
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4063/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
trivikr pushed a commit that referenced this pull request Nov 21, 2019
@lundibundi @trivikr
doc: add mention for using promisify on class methods
8138e9c 
Fixes: #30344

PR-URL: #30355
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@trivikr
Copy link
Member

trivikr commented Nov 21, 2019

Landed in 8138e9c

@trivikr trivikr closed this Nov 21, 2019
MylesBorins pushed a commit that referenced this pull request Nov 21, 2019
@lundibundi @MylesBorins
doc: add mention for using promisify on class methods
ab887bd 
Fixes: #30344

PR-URL: #30355
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Nov 21, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@lundibundi @targos
doc: add mention for using promisify on class methods
51a92b9 
Fixes: #30344

PR-URL: #30355
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@lundibundi @MylesBorins
doc: add mention for using promisify on class methods
e10f922 
Fixes: #30344

PR-URL: #30355
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@devsnek devsnek devsnek left review comments

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

util.promisify does not work as expected with object methods
7 participants
@lundibundi @BridgeAR @trivikr @jasnell @Trott @devsnek @nodejs-github-bot