Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: set module version 72 to node 12 #29877

Closed

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Oct 7, 2019

Clearly state the modules version 72 is official node 12, similar as it
is done for other major node versions.

Checklist

Clearly state the modules version 72 is official node 12, similar as it
is done for other major node versions.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 7, 2019
@richardlau
Copy link
Member

I'm hesitant to add more work for our releasers, but should this step be added to the release process for majors?

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2019
@nodejs-github-bot
Copy link
Collaborator

@mmarchini
Copy link
Contributor

Landed in 8b9a578

@mmarchini mmarchini closed this Oct 10, 2019
mmarchini pushed a commit that referenced this pull request Oct 10, 2019
Clearly state the modules version 72 is official node 12, similar as it
is done for other major node versions.

PR-URL: #29877
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Flarna Flarna deleted the abi-version-registry branch October 10, 2019 19:09
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos pushed a commit that referenced this pull request Oct 14, 2019
Clearly state the modules version 72 is official node 12, similar as it
is done for other major node versions.

PR-URL: #29877
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.