Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: prohibit Error.prepareStackTrace usage #29827

Closed
wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Oct 3, 2019

This eslint rule makes sure that prepareStackTrace is not used in
Node.js core.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This eslint rule makes sure that `prepareStackTrace` is not used in
Node.js core.
lib/.eslintrc.yaml Outdated Show resolved Hide resolved
@BridgeAR
Copy link
Member Author

BridgeAR commented Oct 3, 2019

@BridgeAR BridgeAR requested a review from devsnek October 3, 2019 12:30
Trott pushed a commit that referenced this pull request Oct 6, 2019
This eslint rule makes sure that `prepareStackTrace()` is not used in
Node.js core.

PR-URL: #29827
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@Trott
Copy link
Member

Trott commented Oct 6, 2019

Landed in 0521a98

If the reason for avoiding prepareStackTrace() isn't already documented somewhere, it would be a good idea to add it somewhere, perhaps doc/guides/using-internal-errors.md.

@Trott Trott closed this Oct 6, 2019
BridgeAR added a commit that referenced this pull request Oct 9, 2019
This eslint rule makes sure that `prepareStackTrace()` is not used in
Node.js core.

PR-URL: #29827
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
@BridgeAR BridgeAR deleted the prohibit-prepare-stack-trace branch January 20, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants