module: pass full URL to loader for top-level load #29736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
approved these changes
Sep 27, 2019
guybedford
added
the
esm
devnexen
approved these changes
Sep 28, 2019
Trott
added
the
author ready
|
Landed in c42ab99 |
Trott
pushed a commit
that referenced
this pull request
Sep 30, 2019
PR-URL: #29736 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
|
@Trott, why wasn't this merged instead of being committed directly? |
See number 5 at https://github.com/nodejs/node/blob/f663b31cc2aecd585e73430504f3d7f5252851ca/COLLABORATOR_GUIDE.md#landing-pull-requests. Adding metadata to commit messages (and often editing the message beyond that) means we end up with a process where this happens. In theory, I could force-push to the contributor's branch to get a purple merge (and I can still do that, I suppose), but I'm usually hesitant to force-push to someone else's branch just for those aesthetics. (Long-term, I hope we can get a commit-queue going that takes care of all this stuff automatically.) |
targos
pushed a commit
that referenced
this pull request
Oct 1, 2019
PR-URL: #29736 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the full URL for the top-level "runMain" to the ESM loader, instead of the pathname. In addition the existing example loader check of the input path type is adjusted to catch the original issue.
This resolves the issue raised in #29610, where the result of
new URL('/C:\path')will throw.It's more of a footgun than an actual bug, since the issue is that the expectation is that the parent URL would be passed (
new URL('/C:\path', pathToFileURL(process.cwd() + path.sep))works fine), but it seems better to be consistent in the use of file URLs input into the loader.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes