Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix some recent nits #29670

Closed
wants to merge 2 commits into from
Closed

doc: fix some recent nits #29670

wants to merge 2 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 23, 2019
@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Sep 23, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3924/

@vsemozhetbyt
Copy link
Contributor Author

Rebased and fixed some more recent nits in the second commit: fixed section place according to the ABC order and removed erroneous backtick that broke formatting.

@BridgeAR
Copy link
Member

Still LGTM

@Trott
Copy link
Member

Trott commented Sep 25, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3930/

@Trott
Copy link
Member

Trott commented Sep 26, 2019

@vsemozhetbyt Sorry, this needs a rebase again.

@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2019
@vsemozhetbyt
Copy link
Contributor Author

Rebased)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25726/

@Trott
Copy link
Member

Trott commented Sep 27, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3934/

Trott pushed a commit that referenced this pull request Sep 27, 2019
@vsemozhetbyt @Trott
doc: fix some recent nits
008a1f6 
PR-URL: #29670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 27, 2019

Landed in 008a1f6

@Trott Trott closed this Sep 27, 2019
@vsemozhetbyt vsemozhetbyt deleted the doc-fix-nits-2019-09-23 branch September 27, 2019 07:56
targos pushed a commit that referenced this pull request Oct 1, 2019
@vsemozhetbyt @targos
doc: fix some recent nits
c2791dc 
PR-URL: #29670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 1, 2019
Merged
@beevelop beevelop mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vsemozhetbyt @ZYSzys @BridgeAR @Trott @nodejs-github-bot @jasnell @addaleax @lpinca @cjihrig