Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix bug in fs module autocompletion #29555

Closed
wants to merge 1 commit into from
Closed

repl: fix bug in fs module autocompletion #29555

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Sep 14, 2019

Fixes: #29424

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Sep 14, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25485/

@ZYSzys
Copy link
Member Author

ZYSzys commented Sep 14, 2019 •
edited
Loading

I wonder why we changed baseName to filePath in #26648 (comment) ?

/cc @BridgeAR @antsmartian

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25495/

@Trott
Copy link
Member

Trott commented Sep 16, 2019

@nodejs/fs @nodejs/repl @BridgeAR @antsmartian This could use some reviews.

antsmartian
antsmartian approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I don't remember, why we changed this, but this is what was actually causing the issue.)

BridgeAR
BridgeAR approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 18, 2019
ZYSzys pushed a commit that referenced this pull request Sep 18, 2019
repl: fix bug in fs module autocompletion
2f497a6 
PR-URL: #29555
Fixes: #29424
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member

Trott commented Sep 18, 2019 •
edited
Loading

Landed in 6ed026f Landed in 2f497a6

@Trott Trott closed this Sep 18, 2019
@ZYSzys
Copy link
Member Author

ZYSzys commented Sep 18, 2019

Landed in 2f497a6 too ? (It seems that we land this at the same time :)

@Trott
Copy link
Member

Trott commented Sep 18, 2019

Landed in 2f497a6 too ? (It seems that we land this at the same time :)

Ha ha! Yes, I posted my comment too soon. Yours landed first and is the one on master now.

@ZYSzys ZYSzys deleted the fix-repl branch September 18, 2019 02:05
targos pushed a commit that referenced this pull request Sep 20, 2019
@targos
repl: fix bug in fs module autocompletion
93ce43e 
PR-URL: #29555
Fixes: #29424
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@BridgeAR
repl: fix bug in fs module autocompletion
7eae707 
PR-URL: #29555
Fixes: #29424
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antsmartian antsmartian antsmartian approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repl: bug in fs module autocompletion
5 participants
@ZYSzys @nodejs-github-bot @Trott @antsmartian @BridgeAR