Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: space around lists #29467

Closed
wants to merge 1 commit into from
Closed

doc: space around lists #29467

wants to merge 1 commit into from

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Sep 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nschonni
doc: space around lists
70b6bc2 
Address markdownlint rule MD032.
Flagged a few mixed list styles.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 6, 2019
@Trott
Copy link
Member

Trott commented Sep 6, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3888/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 9, 2019
trivikr pushed a commit that referenced this pull request Sep 9, 2019
@nschonni @trivikr
doc: space around lists
c929b15 
Address markdownlint rule MD032.
Flagged a few mixed list styles.

PR-URL: #29467
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@trivikr
Copy link
Member

trivikr commented Sep 9, 2019

Landed in c929b15

@trivikr trivikr closed this Sep 9, 2019
@nschonni nschonni deleted the doc--space-around-lists branch September 10, 2019 00:16
@Trott
Copy link
Member

Trott commented Sep 10, 2019 •
edited
Loading

@trivikr @nschonni Not a terribly big deal, but if you could try to make sure the first word after the subsystem in the commit message is an imperative verb (enforce, add, remove, check, something like that), it would help keep our auto-generated change logs consistent and understandable. Thanks! (I usually edit other contributors' commit messages before landing rather than leave nits about this sort of thing but I can change my ways if it helps.)

@Trott
Copy link
Member

Trott commented Sep 10, 2019

(So this one might be doc: add space around lists or doc: enforce lint rule for space around lists or something like that. Totally minor and we will never get 100% compliance on this, so feel free to only half-remember this comment.)

targos pushed a commit that referenced this pull request Sep 20, 2019
@nschonni @targos
doc: space around lists
22ad9ed 
Address markdownlint rule MD032.
Flagged a few mixed list styles.

PR-URL: #29467
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@nschonni @BridgeAR
doc: space around lists
2a53401 
Address markdownlint rule MD032.
Flagged a few mixed list styles.

PR-URL: #29467
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devnexen devnexen devnexen approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nschonni @Trott @trivikr @cjihrig @devnexen @nodejs-github-bot