Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: http2 anchor link formatting and reference #29362

Closed
wants to merge 1 commit into from
Closed

doc: http2 anchor link formatting and reference #29362

wants to merge 1 commit into from

Conversation

nschonni
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nschonni
doc: http2 anchor link formatting and reference
2dba702 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 29, 2019
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Aug 29, 2019 •
edited
Loading

Thank you. Before this PR, these links were broken in the rendered pages, both GitHub (.md) and Node,js doctools (.html) variants (linked to the parent folder or just the document).

@trivikr
Copy link
Member

trivikr commented Aug 30, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3870/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 30, 2019
@Trott
Copy link
Member

Trott commented Aug 31, 2019

Landed in ee8f02b

@Trott Trott closed this Aug 31, 2019
Trott pushed a commit that referenced this pull request Aug 31, 2019
@nschonni @Trott
doc: format http2 anchor link and reference
ee8f02b 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.

PR-URL: #29362
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@nschonni nschonni deleted the doc--http2-anchor-link-formatting-and-reference branch August 31, 2019 22:33
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@nschonni @BridgeAR
doc: format http2 anchor link and reference
ebd2e7b 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.

PR-URL: #29362
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@nschonni @BridgeAR
doc: format http2 anchor link and reference
187d08b 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.

PR-URL: #29362
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nschonni @vsemozhetbyt @trivikr @Trott @jasnell @lpinca @cjihrig @nodejs-github-bot