deps: python3 compat for inspector code generator #29346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
added
the
python
nodejs-github-bot
added
tools
|
This change should also be made upstream https://github.com/v8/v8/blob/master/third_party/inspector_protocol/code_generator.py#L45 |
4 tasks
For the record: not also but first. :-) |
|
The real upstream is here: https://chromium.googlesource.com/deps/inspector_protocol/ |
|
Closing in favor of #29340. |
This was referenced Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code generator takes a dict and turns it into a namedtuple. The dict
contains the key "async", which is a keyword in Python >= 3.7, and rejected
by the namedtuple constructor. Rename it to "async_" to avoid the clash.
Fixes: #29326
This PR replicates the functionality of #29340 but modifies
deps/v8/third_party/inspector_protocol/code_generator.py instead of
tools/inspector_protocol/code_generator.py which actually solves
#29326 and allows Python 3.7 to perform similar to Python 3.6 in
Travis CI tests.
Given the completely derivative nature of this PR vs. #29340, I will happily
close this PR if #29340 is modified to make changes to the deps file instead
of the tools file.