Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: heading levels should only increment by one #29331

Closed
wants to merge 1 commit into from
Closed

doc: heading levels should only increment by one #29331

wants to merge 1 commit into from

Conversation

nschonni
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nschonni
doc: heading levels should only increment by one
761aa1e 
These are flagged by Markdownlint MD001 rule.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 27, 2019
@trivikr
Copy link
Member

trivikr commented Aug 27, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3861/

@trivikr trivikr added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. labels Aug 27, 2019
@Trott
Copy link
Member

Trott commented Aug 29, 2019

Landed in 9e8edb0

@Trott Trott closed this Aug 29, 2019
Trott pushed a commit that referenced this pull request Aug 29, 2019
@nschonni @Trott
doc: heading levels should only increment by one
9e8edb0 
These are flagged by Markdownlint MD001 rule.

PR-URL: #29331
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nschonni nschonni deleted the fix-md001 branch August 29, 2019 12:37
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@nschonni @BridgeAR
doc: heading levels should only increment by one
9c9d9e7 
These are flagged by Markdownlint MD001 rule.

PR-URL: #29331
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@nschonni @BridgeAR
doc: heading levels should only increment by one
bb72217 
These are flagged by Markdownlint MD001 rule.

PR-URL: #29331
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nschonni @trivikr @Trott @jasnell @lpinca @cjihrig @nodejs-github-bot