Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: display timeEnd with suitable time unit #29251

Closed
wants to merge 9 commits into from
Closed

console: display timeEnd with suitable time unit #29251

wants to merge 9 commits into from

Commits on Aug 23, 2019

  1. console: display timeEnd with suitable time unit 

    When timeEnd function is called, display result with a suitable
time unit instead of a big amount of milliseconds.

Refs: #29099
    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    b00bdf6 View commit details
    Browse the repository at this point in the history

  2. console: extract formatTime and export it for test 

    Extract the format time part to be able to test it.
    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    c4eb2d6 View commit details
    Browse the repository at this point in the history

  3. test: adapt tests 

    Change regexp of test-console to accept other possible units and create test for formatTime
    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    dc97305 View commit details
    Browse the repository at this point in the history

  4. console: don't trim formatTime value before returning it 

    Tests in test-console.js expect 3 floating points.
    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    106bbd4 View commit details
    Browse the repository at this point in the history

  5. test: adapt formatTime tests to previous commit 

    Assert that returnes value as 3 floating points
    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    510ef86 View commit details
    Browse the repository at this point in the history

  6. console: fix linter 

    Edit the file to fulfill the linter requirements
    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    57bbc6c View commit details
    Browse the repository at this point in the history

  7. test: fix linter 

    Edit the file to fulfill the linter requirements
    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    c5063d0 View commit details
    Browse the repository at this point in the history

  8. console: move magic numbers to constants 

    Hour, minute and second equivalent in ms are now constants.
    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    368e5d7 View commit details
    Browse the repository at this point in the history

  9. test: add blank line

    @Xstoudi
    Xstoudi committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    da4e02f View commit details
    Browse the repository at this point in the history