http: simplify timeout handling #29200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
http-client-req-timeout-refactor
branch
from
58a84b6
to
2c4cc01
Compare
lpinca
reviewed
Aug 19, 2019
Avoids allocating and registering extra listeners for 'timeout'.
ronag
force-pushed
the
http-client-req-timeout-refactor
branch
from
2c4cc01
to
6f54858
Compare
lpinca
approved these changes
Aug 19, 2019
BridgeAR
approved these changes
Aug 20, 2019
|
Landed in cad3a21. |
lpinca
pushed a commit
that referenced
this pull request
Aug 31, 2019
Avoids allocating and registering extra listeners for 'timeout'. PR-URL: #29200 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Avoids allocating and registering extra listeners for 'timeout'. PR-URL: #29200 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
Avoids allocating and registering extra listeners for 'timeout'. PR-URL: #29200 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids allocating and registering extra listeners for 'timeout'.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes