stream: avoid unecessary nextTick #29194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
changed the title
ronag
force-pushed
the
stream-emit-close
branch
2 times, most recently
from
a2cd837
to
5ad1869
Compare
trivikr
reviewed
Aug 20, 2019
If we are not going to emit 'close' then there is no reason to schedule it.
ronag
force-pushed
the
stream-emit-close
branch
from
5ad1869
to
3489245
Compare
trivikr
approved these changes
Aug 20, 2019
jasnell
approved these changes
Aug 21, 2019
|
Landed in 033037c |
Trott
pushed a commit
that referenced
this pull request
Aug 23, 2019
If we are not going to emit 'close' then there is no reason to schedule it. PR-URL: #29194 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Should this be backported to at least v12.x? If so, this requires a manual backport due to multiple conflicts. Here is a guide how to create manual backports. |
|
@BridgeAR I'm a new to the whole backporting thing. I'm more than happy to try and prepare it. However, should we really be backporting this? It doesn't actually fix any bug and is just a minor cleanup and perf improvement. |
|
@ronag backporting is often not about the actual fix but to reduce followup conflicts. It would be great if you could give it a try! |
4 tasks
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 9, 2019
If we are not going to emit 'close' then there is no reason to schedule it. PR-URL: nodejs#29194 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: nodejs#29691
|
quick ping re: backport |
|
@MylesBorins: This was further refactored. I don't believe this is relevant anymore for backport. |
sxa
pushed a commit
to sxa/node
that referenced
this pull request
Jan 24, 2020
If we are not going to emit 'close' then there is no reason to schedule it. PR-URL: nodejs#29194 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are not going to emit
'close'then there is no reason to schedule it.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes