Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: rename validateSafeInteger to validateInteger #29184

Merged
merged 1 commit into from
Aug 19, 2019
Merged

lib: rename validateSafeInteger to validateInteger #29184

merged 1 commit into from
Aug 19, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 17, 2019

validateInteger() was renamed to validateSafeInteger() in #26572. However, this function also works with unsafe integers. This commit restores the old name, and adds some basic tests.

Refs: #26572

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Aug 17, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25061/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 18, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25068/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 19, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25087/

EDIT: CI was green.

@cjihrig
lib: rename validateSafeInteger to validateInteger
3238232 
validateInteger() was renamed to validateSafeInteger() in
nodejs#26572. However, this
function also works with unsafe integers. This commit restores
the old name, and adds some basic tests.

PR-URL: nodejs#29184
Refs: nodejs#26572
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig cjihrig merged commit 3238232 into nodejs:master Aug 19, 2019
@cjihrig cjihrig deleted the ints branch August 19, 2019 15:57
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @jasnell @Trott @lpinca @trivikr @ZYSzys @targos