Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing deprecation number #29183

Merged
merged 1 commit into from
Aug 19, 2019
Merged

doc: add missing deprecation number #29183

merged 1 commit into from
Aug 19, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 17, 2019

#29015 landed with the new deprecation listed as DEP0XXX. This commit assigns the new deprecation a valid ID.

Refs: #29015

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Aug 17, 2019
@jasnell
Copy link
Member

jasnell commented Aug 18, 2019

Perhaps we could use a Github action to catch these 😉

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 18, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 19, 2019

Green lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3836/

@cjihrig
doc: add missing deprecation number
37321a9 
nodejs#29015 landed with the
new deprecation listed as DEP0XXX. This commit assigns
the new deprecation a valid ID.

Refs: nodejs#29015
PR-URL: nodejs#29183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig cjihrig merged commit 37321a9 into nodejs:master Aug 19, 2019
@cjihrig cjihrig deleted the depr branch August 19, 2019 15:34
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@lpinca lpinca lpinca approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.