Exported method can be static; will never be called directly #29102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
|
No, you don't need it, but you might want it (encapsulation principle). :-) I don't see any reason for having this being a symbol with global scope (as opposed to: module scope). |
addaleax
approved these changes
Aug 13, 2019
|
I think this is okay, but since these are test addons, it really doesn’t make a difference in practice. |
cjihrig
approved these changes
Aug 13, 2019
rpoisel
force-pushed
the
pr-hello-static
branch
from
7e7f42f
to
373aa3a
Compare
rpoisel
force-pushed
the
pr-hello-static
branch
from
373aa3a
to
9209b14
Compare
patilharshal16
approved these changes
Aug 14, 2019
Trott
approved these changes
Aug 16, 2019
|
Landed in 71b5ce5 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 16, 2019
The exported method can be static as it will never be called directly. PR-URL: nodejs#29102 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
The exported method can be static as it will never be called directly. PR-URL: #29102 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) passes