Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix sorting nit in sections of http.md #28943

Closed
wants to merge 1 commit into from
Closed

doc: fix sorting nit in sections of http.md #28943

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Aug 2, 2019
@vsemozhetbyt
Copy link
Contributor Author

Rebased to resolve a conflict.

@Trott
Copy link
Member

Trott commented Aug 2, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3820/

@Trott
Copy link
Member

Trott commented Aug 2, 2019

+1 here to fast-track

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 2, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 3, 2019
@vsemozhetbyt @Trott
doc: fix sorting nit in sections of http.md
747ddd5 
PR-URL: nodejs#28943
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 3, 2019

Landed in 747ddd5

@Trott Trott closed this Aug 3, 2019
@vsemozhetbyt vsemozhetbyt deleted the doc-http-sort-nit branch August 3, 2019 15:30
BridgeAR pushed a commit that referenced this pull request Aug 6, 2019
@vsemozhetbyt @BridgeAR
doc: fix sorting nit in sections of http.md
57f5d50 
PR-URL: #28943
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @Trott @cjihrig @richardlau @nodejs-github-bot