test: fix nits in test/fixtures/tls-connect.js #28880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
commented
Jul 28, 2019
| @@ -92,7 +92,7 @@ exports.connect = function connect(options, callback) { | |||
| function maybeCallback() { | |||
| if (!callback) | |||
| return; | |||
| if (server.conn && (client.conn || client.err)) { | |||
There was a problem hiding this comment.
client.err is set by the 'error' listener of the client socket or in the catch branch of the try...catch around tls.connect(). In the latter case maybeCallback() is not used as the callback is called directly. In the former client.conn is also set.
cjihrig
approved these changes
Jul 29, 2019
jasnell
approved these changes
Jul 29, 2019
Trott
approved these changes
Jul 30, 2019
Trott
added
the
author ready
|
Landed in 834a413 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
PR-URL: nodejs#28880 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28880 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes