Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use unique tmpdirs for each test #28858

Closed
wants to merge 11 commits into from
Closed

test: use unique tmpdirs for each test #28858

wants to merge 11 commits into from

Commits on Aug 7, 2019

  1. test: use unique tmpdirs for each test 

    Tests can leave processes running blocking the tmpdir. This does not
yet prevent tests from doing that, but prevents failures on
subsequent tests.
    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    7a65a6f View commit details
    Browse the repository at this point in the history

  2. fs: close file descriptor of promisified truncate

    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    326392f View commit details
    Browse the repository at this point in the history

  3. repl: close file descriptor of history file

    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    1d38c77 View commit details
    Browse the repository at this point in the history

  4. benchmark: use test/common/tmpdir consistently 

    Many benchmarks use test/common/tmpdir. This changes 3 benchmarks that use
NODE_TMPDIR to also use test/common/tmpdir.

This is necessary in preparation for the next commit that changes tmpdir to
delete tmpdir.path when the Node.js process exits. Thus, if multiple
benchmarks are run sequentially, the ones that use tmpdir will remove the
directory and the ones changed here would fail because it does not exist.
This happens when running test/benchmark.

Note: to explicitly select a directory for tmpdir, use NODE_TEST_DIR.
    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    a20031f View commit details
    Browse the repository at this point in the history

  5. test: clean tmpdir on process exit

    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    a686feb View commit details
    Browse the repository at this point in the history

  6. fixup! test: clean tmpdir on process exit 

    Suggestions by Rich Trott
    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    91b6d55 View commit details
    Browse the repository at this point in the history

  7. fixup! test: clean tmpdir on process exit 

    Fixes for workers
    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    d68f316 View commit details
    Browse the repository at this point in the history

  8. fixup! test: clean tmpdir on process exit 

    Fixes for pummel tests
    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    2423e41 View commit details
    Browse the repository at this point in the history

  9. fixup! test: clean tmpdir on process exit 

    Warn about NFS files
    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    debcba4 View commit details
    Browse the repository at this point in the history

  10. fixup! test: clean tmpdir on process exit 

    Fixes for Linux open files
    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    b339245 View commit details
    Browse the repository at this point in the history

  11. fixup! test: clean tmpdir on process exit

    @joaocgreis
    joaocgreis committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    3c67878 View commit details
    Browse the repository at this point in the history