Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mention unit for event loop delay measurements #28629

Closed
wants to merge 1 commit into from
Closed

doc: mention unit for event loop delay measurements #28629

wants to merge 1 commit into from

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Jul 10, 2019 •
edited
Loading

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Jul 10, 2019
bcoe
bcoe approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I found the lack of unit confusing, might be worth adding notes about units in a few more places. but, I fully endorse this clarification being added.

@jkrems jkrems requested a review from jasnell July 10, 2019 20:26
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24367/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2019
@jkrems jkrems added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 11, 2019
@jkrems
Copy link
Contributor Author

jkrems commented Jul 11, 2019

Given the size of the change and the lack of disagreement, I hereby apply for fast-tracking. :)

pull bot pushed a commit to tkamenoko/node that referenced this pull request Jul 11, 2019
@jkrems @addaleax
doc: mention unit for event loop delay measurements
ca0884a 
PR-URL: nodejs#28629
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax
Copy link
Member

Landed in ca0884a

@addaleax addaleax closed this Jul 11, 2019
@jkrems jkrems deleted the eld-unit branch July 11, 2019 21:08
targos pushed a commit that referenced this pull request Jul 20, 2019
@jkrems @targos
doc: mention unit for event loop delay measurements
0aca527 
PR-URL: #28629
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jkrems @nodejs-github-bot @addaleax @bcoe @cjihrig @gireeshpunathil @BridgeAR