doc: add a link to the throw-deprecations flag. #28625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
deprecations
lpinca
approved these changes
Jul 10, 2019
|
|
crap, let me fix those commit message issues |
Motivation: On the deprecated api's doc, the --pending-deprecation flag is a clickable link to the command line docs. This makes the --throw-deprecation flag, which is described in the next paragraph also a link to keep things consistent
lholmquist
force-pushed
the
link_to_throw_deprecation
branch
from
dc1a467
to
b96ada2
Compare
lpinca
approved these changes
Jul 10, 2019
richardlau
approved these changes
Jul 10, 2019
addaleax
approved these changes
Jul 10, 2019
cjihrig
approved these changes
Jul 11, 2019
gengjiawen
approved these changes
Jul 11, 2019
BridgeAR
approved these changes
Jul 11, 2019
BridgeAR
added
the
author ready
Trott
approved these changes
Jul 12, 2019
|
Landed in d38b075 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 12, 2019
Motivation: On the deprecated api's doc, the --pending-deprecation flag is a clickable link to the command line docs. This makes the --throw-deprecation flag, which is described in the next paragraph also a link to keep things consistent PR-URL: nodejs#28625 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
Motivation: On the deprecated api's doc, the --pending-deprecation flag is a clickable link to the command line docs. This makes the --throw-deprecation flag, which is described in the next paragraph also a link to keep things consistent PR-URL: #28625 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: On the deprecated api's doc, the
--pending-deprecationflag is a clickable link to the command line docs.This commit makes the
--throw-deprecationflag, which is described in the next paragraph of that doc, also a link.This is to keep things consistent
Checklist