Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: format Unix consistently #28576

Merged
merged 1 commit into from
Jul 8, 2019
Merged

doc: format Unix consistently #28576

merged 1 commit into from
Jul 8, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 6, 2019

Update the API docs to always spell as Unix for consistency.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 6, 2019
bnoordhuis
bnoordhuis approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to have a doc lint rule.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 6, 2019

Would be nice to have a doc lint rule.

Agreed. It's a bit annoying that the doc rules exist outside of core.

@Trott
Copy link
Member

Trott commented Jul 6, 2019

Would be nice to have a doc lint rule.

Agreed. It's a bit annoying that the doc rules exist outside of core.

Yeah, I'd be for reversing the flow to make this easier on us. In other words, instead of adding a rule to the remark-lint-prohibited-strings and then bringing it into core, it would be great to add the rule to core and then publish remark-lint-prohibited-strings in case other projects (in the nodejs org in particular) want to use our markdown linting rules (which none of them do as far as I know).

That might also involve undoing some or all of the rollup stuff for lint-md too, though.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 7, 2019

Green Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3748/

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2019
mhdawson
mhdawson approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
doc: format Unix consistently
e04ee9b 
Update the API docs to always spell as Unix.

PR-URL: nodejs#28576
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cjihrig cjihrig merged commit e04ee9b into nodejs:master Jul 8, 2019
@cjihrig cjihrig deleted the unix branch July 8, 2019 17:36
targos pushed a commit that referenced this pull request Jul 20, 2019
@cjihrig @targos
doc: format Unix consistently
2205818 
Update the API docs to always spell as Unix.

PR-URL: #28576
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @Trott @bnoordhuis @addaleax @lpinca @gireeshpunathil @BridgeAR @mhdawson @nodejs-github-bot