Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: address missing paren #28483

Merged
merged 1 commit into from
Jul 2, 2019
Merged

doc: address missing paren #28483

merged 1 commit into from
Jul 2, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 30, 2019

The closing paren was missing. Move to using commas instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jun 30, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 1, 2019

Green Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3728/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2019
@cjihrig
doc: address missing paren
e1f27ef 
The closing paren was missing. Move to using commas instead.

PR-URL: nodejs#28483
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@cjihrig cjihrig merged commit e1f27ef into nodejs:master Jul 2, 2019
@cjihrig cjihrig deleted the missing-paren branch July 2, 2019 16:19
targos pushed a commit that referenced this pull request Jul 20, 2019
@cjihrig @targos
doc: address missing paren
0a0832f 
The closing paren was missing. Move to using commas instead.

PR-URL: #28483
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @Trott @addaleax @lpinca @gengjiawen @richardlau @BridgeAR @trivikr @nodejs-github-bot