Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: cleanup isDead() example #28421

Merged
merged 1 commit into from
Jun 27, 2019
Merged

doc: cleanup isDead() example #28421

merged 1 commit into from
Jun 27, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 25, 2019

This commit removes extra whitespace and some awkward text containing typos from the cluster worker.isDead() code sample.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Jun 25, 2019
@Trott
Copy link
Member

Trott commented Jun 25, 2019 •
edited
Loading

Super micro-nit: s/cleanup/clean up/ in commit message?

@trivikr
Copy link
Member

trivikr commented Jun 25, 2019

Feel free to 👍 this comment to approve fast-tracking

@trivikr trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 25, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 26, 2019

Green Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3716/

@cjihrig
doc: clean up isDead() example
63a5cd8 
This commit removes extra whitespace and some awkward text
containing typos from the cluster worker.isDead() code
sample.

PR-URL: nodejs#28421
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit 63a5cd8 into nodejs:master Jun 27, 2019
@cjihrig cjihrig deleted the cluster branch June 27, 2019 13:52
targos pushed a commit that referenced this pull request Jul 2, 2019
@cjihrig @targos
doc: clean up isDead() example
4972bc4 
This commit removes extra whitespace and some awkward text
containing typos from the cluster worker.isDead() code
sample.

PR-URL: #28421
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@cjihrig @targos
doc: clean up isDead() example
96e8b98 
This commit removes extra whitespace and some awkward text
containing typos from the cluster worker.isDead() code
sample.

PR-URL: #28421
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @Trott @trivikr @jasnell @lpinca @BridgeAR @nodejs-github-bot