Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: add readline.promises #28407

Closed
wants to merge 8 commits into from
Closed

readline: add readline.promises #28407

wants to merge 8 commits into from

Commits on Jul 10, 2019

  1. lib: rename lib/internal/readline.js 

    This commit moves lib/internal/readline.js to
lib/internal/readline/utils.js. This is in preparation of
adding a readline.promises implementation.
    @cjihrig
    cjihrig committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    166483a View commit details
    Browse the repository at this point in the history

  2. readline: move Interface to separate file 

    This commit moves the readline Interface class to its own
file. All other readline logic is moved into the internal
readline utils file.
    @cjihrig
    cjihrig committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    f763ff0 View commit details
    Browse the repository at this point in the history

  3. readline: use named constant for surrogate checks 

    This commit defines a named constant instead of using a mix of
2 ** 16 and 0X10000 throughout the code.
    @cjihrig
    cjihrig committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    9ff7ccb View commit details
    Browse the repository at this point in the history

  4. readline: replace last uses var 

    This changes the last two `var` uses in the readline code
to `let`.
    @cjihrig
    cjihrig committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    9639082 View commit details
    Browse the repository at this point in the history

  5. readline: refactor _tabComplete() 

    This commit refactors _tabComplete() to only pause the interface,
call the completer() function, and then call another function to
handle the results. This will make it simpler to support a
promises based completer() function without duplicating much
code.
    @cjihrig
    cjihrig committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    74da761 View commit details
    Browse the repository at this point in the history

  6. readline: centralize Interface argument parsing 

    This commit moves all Interface() constructor argument parsing
into a helper function.
    @cjihrig
    cjihrig committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    93d3cf8 View commit details
    Browse the repository at this point in the history

  7. readline: add readline.promises 

    This commit exposes a Promise based version of the readline API.
    @cjihrig
    cjihrig committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    11c8737 View commit details
    Browse the repository at this point in the history

  8. fixup! readline: add readline.promises 

    Remove the readline.promises experimental warning per
PR review comment.
    @cjihrig
    cjihrig committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    edcdf05 View commit details
    Browse the repository at this point in the history