esm: ensure cwd-relative imports for module --eval #28389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
module-rel-eval
branch
2 times, most recently
from
b81a426
to
5e88cde
Compare
guybedford
force-pushed
the
module-rel-eval
branch
from
5e88cde
to
682b079
Compare
cjihrig
approved these changes
Jun 28, 2019
|
Landed in 4565292. |
guybedford
added a commit
that referenced
this pull request
Jun 30, 2019
PR-URL: #28389 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28389 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28389 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28160 ensuring that when using
node --experimental-modules --input-type module --eval, that anyimportstatements are cwd-relative.Huge thanks to @zeckson for setting up these tests to begin with and @Avaq for the clear issue report on this!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes