Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change the repeat Buffer.from('blerg'); statments #28372

Closed
wants to merge 1 commit into from
Closed

test: change the repeat Buffer.from('blerg'); statments #28372

wants to merge 1 commit into from

Conversation

themiken
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 21, 2019
@ZYSzys ZYSzys added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jun 22, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24051/

@Trott
Copy link
Member

Trott commented Jun 22, 2019

Welcome @themiken and thanks for the pull request! I imagine this was given as an assignment at code-and-learn and I won't block this, but I do wish to comment in case someone sees this kind of change and decides to look for similar changes in the test code base:

Honestly I think these kinds of changes make the tests more difficult to read and understand, not easier. If the buffer were meaningful, then abstracting it to a variable would make sense. But when it's just "I need a buffer, any buffer, to use in this test", inlining Buffer.from('blerg') makes that more clear than bufferBlerg.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24076/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24083/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2019
@Trott
Copy link
Member

Trott commented Jul 6, 2019

Landed in 04cf202

@Trott Trott closed this Jul 6, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 6, 2019
@themiken @Trott
test: change the repeat Buffer.from('blerg'); statments
04cf202 
PR-URL: nodejs#28372
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member

Trott commented Jul 6, 2019

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Jul 20, 2019
@themiken @targos
test: change the repeat Buffer.from('blerg'); statments
4c333f4 
PR-URL: #28372
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@themiken @nodejs-github-bot @Trott @jasnell @BridgeAR @trivikr @ZYSzys