Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix sentence about Http2Stream destruction #28336

Merged
merged 1 commit into from
Jun 24, 2019
Merged

doc: fix sentence about Http2Stream destruction #28336

merged 1 commit into from
Jun 24, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 21, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Jun 21, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Jun 22, 2019 •
edited by cjihrig
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3701/

EDIT(cjihrig): CI was green.

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 22, 2019
@cjihrig
doc: fix sentence about Http2Stream destruction
6f5b5d1 
PR-URL: nodejs#28336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig cjihrig merged commit 6f5b5d1 into nodejs:master Jun 24, 2019
@cjihrig cjihrig deleted the typo2 branch June 24, 2019 17:39
targos pushed a commit that referenced this pull request Jul 2, 2019
@cjihrig @targos
doc: fix sentence about Http2Stream destruction
d25d40e 
PR-URL: #28336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @ZYSzys @jasnell @Trott @lpinca @BridgeAR @nodejs-github-bot